Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logs: Add partition to warning upon log Truncation #489

Merged
merged 1 commit into from
Dec 5, 2022
Merged

logs: Add partition to warning upon log Truncation #489

merged 1 commit into from
Dec 5, 2022

Conversation

Ehud-Lev-Forter
Copy link
Contributor

@Ehud-Lev-Forter Ehud-Lev-Forter commented Dec 4, 2022 •
edited by astubbs
Loading

Adding partition to warn Truncating log

Description...

Checklist

  • Documentation (if applicable)
  • Changelog

@Ehud-Lev-Forter
Fix:
0c1c905 
Adding partition to warn Truncating log
astubbs
astubbs approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@astubbs astubbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ready to merge?

@Ehud-Lev-Forter
Copy link
Contributor Author

@astubbs Yes please

@astubbs
Copy link
Contributor

astubbs commented Dec 5, 2022

Ok. FYI SNAPSHOT should be ready within 30 after the build finishes.

@astubbs astubbs changed the title Fix: Adding partition to warn Truncating log logs: Adds partition to warning upon log Truncation Dec 5, 2022
@astubbs astubbs changed the title logs: Adds partition to warning upon log Truncation logs: Add partition to warning upon log Truncation Dec 5, 2022
@astubbs astubbs merged commit f7fceaf into confluentinc:master Dec 5, 2022
@lennehendrickx lennehendrickx mentioned this pull request Mar 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astubbs astubbs astubbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ehud-Lev-Forter @astubbs