Introduce request attribute to enable global metrics use runtime request tags #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uest tags in the metrics
trnguyencflt
force-pushed
the
KREST-10466-enable-tenant-level-metrics-jersey
branch
from
1d97936
to
b157898
Compare
msn-tldr
reviewed
Jun 13, 2023
core/src/main/java/io/confluent/rest/metrics/MetricsResourceMethodApplicationListener.java
Outdated
Show resolved
Hide resolved
.../java/io/confluent/rest/metrics/MetricsResourceMethodApplicationListenerIntegrationTest.java
Outdated
Show resolved
Hide resolved
|
@msn-tldr the other PR is here https://github.com/confluentinc/ce-kafka-rest/pull/464/ please have a look 👍 , thanks |
msn-tldr
reviewed
Jun 16, 2023
core/src/main/java/io/confluent/rest/metrics/MetricsResourceMethodApplicationListener.java
Outdated
Show resolved
Hide resolved
…FIG instead of evaluating from request
msn-tldr
reviewed
Jun 20, 2023
.../java/io/confluent/rest/metrics/MetricsResourceMethodApplicationListenerIntegrationTest.java
Show resolved
Hide resolved
msn-tldr
reviewed
Jun 20, 2023
.../java/io/confluent/rest/metrics/MetricsResourceMethodApplicationListenerIntegrationTest.java
Show resolved
Hide resolved
msn-tldr
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a request attribute
GLOBAL_STATS_REQUEST_TAGS_ENABLED_PROP_KEYto enable global stats (metrics for all resource methods) to include runtime tags from the requests.This will enable us to have tenant metrics whenever tenant tag is set in application resources (from ce-kafka-rest) for example.
This attributes is also used to keep the compatibility with all downstream apps that use
rest-utils.PR for
ce-kafka-restwill be followup after this.