Make sure that ErrorMessage is always interpreted as json in Response #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trnguyencflt
force-pushed
the
KREST-11086-fix-response-builder
branch
from
d2a7094
to
ee1a641
Compare
Integration to show that without explicit MediaType, Options requests can make server fails with 500
trnguyencflt
force-pushed
the
KREST-11086-fix-response-builder
branch
from
ee1a641
to
1f57603
Compare
ehumber
reviewed
Jul 21, 2023
|
Does WebApplicationExceptionMapper need the same change? |
ehumber
approved these changes
Jul 21, 2023
We don't need it here as it's already set in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title said, this makes sure that we explicitly specify application/json media type for ErrorMessage, otherwise, with Options request, it can return 500