KREST-11276 - Fixing cert reload with multiple registered listeners #409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though Multiple FileWatchers are created for multiple listeners but they execute on
static
single thread pool. As therun
method continuously executes hence only one among multiple submitted FileWatcher will run.When SslFactory registers multiple listeners for cert dynamic reload then only one among listener will get new certificate.
Current PR creates individual thread executor which guarantees execution of all FileWatcher and cert reload on all listener.
We might do better here in future with registering all file change notifications. Rather than creating multiple file watcher services we can register for change notification over common single executor.