Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KREST-11276 - Fixing cert reload with multiple registered listeners #409

Merged
merged 1 commit into from Aug 18, 2023

Conversation

apoorvmittal10
Copy link
Member

Though Multiple FileWatchers are created for multiple listeners but they execute on static single thread pool. As the run method continuously executes hence only one among multiple submitted FileWatcher will run.

jmap -histo 1 | grep -e FileWatcher
4360:             2             64  io.confluent.rest.FileWatcher
8205:             1             16  io.confluent.rest.FileWatcher$1

When SslFactory registers multiple listeners for cert dynamic reload then only one among listener will get new certificate.

Current PR creates individual thread executor which guarantees execution of all FileWatcher and cert reload on all listener.

We might do better here in future with registering all file change notifications. Rather than creating multiple file watcher services we can register for change notification over common single executor.

@apoorvmittal10 apoorvmittal10 requested review from a team as code owners August 18, 2023 14:52
@cla-assistant
Copy link

cla-assistant bot commented Aug 18, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@msn-tldr msn-tldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apoorvmittal10 apoorvmittal10 merged commit 7f5c03c into master Aug 18, 2023
4 checks passed
@apoorvmittal10 apoorvmittal10 deleted the am-cert branch August 18, 2023 16:14
MINHN98 pushed a commit that referenced this pull request Sep 29, 2023
KREST-11276 - Fixing cert reload with multiple registered listeners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants