KREST-7955 421 misdirected request if host does not match SNI #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewJSchofield
approved these changes
Sep 7, 2023
msn-tldr
requested changes
Sep 11, 2023
There was a problem hiding this comment.
@trnguyencflt Thinking more on it, it requires more work to be ready. This new feature should have "config" that acts as a feature-flag to safely roll this out. But agree with the change so far 👍
This will be done on the subsequent cc-spec change (when http2 enable -> enable sni check) (https://confluentinc.atlassian.net/browse/KREST-11523) For this PR, it is complete on its own because we have a configuration to switch it on/off. |
…vletContextHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SniHandler that checks for SNI against the host of the request, if they don't match, response with 421.
This handler is controlled by configuration to turn off/on, default is disabled.
sni.check.enabledJira ticket