Skip to content

Commit

Permalink
Updated unittest
Browse files Browse the repository at this point in the history
  • Loading branch information
@MINHN98
MINHN98 committed May 4, 2023
1 parent f421c59 commit 3e4e14f
Showing 1 changed file with 47 additions and 30 deletions.
77 changes: 47 additions & 30 deletions core/src/test/java/io/confluent/kafka/schemaregistry/rest/RequestHeaderBuilderTest.java
View file
Expand Up @@ -24,6 +24,7 @@
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.HashMap;

import javax.ws.rs.core.HttpHeaders;

Expand All @@ -36,7 +37,8 @@ public void testHeaderProperties(){
HttpHeaders httpHeaders = mockHttpHeaders(ImmutableMap.of(
"Content-Type", "application/json",
"Accept", "application/json",
"Authorization", "test"
"Authorization", "test",
"X-Request-ID", "24b9afef-3cc7-4e32-944d-f89253c1b64b"
));

RequestHeaderBuilder requestHeaderBuilder = new RequestHeaderBuilder();
Expand All @@ -46,6 +48,7 @@ public void testHeaderProperties(){
Assert.assertEquals("application/json", requestProps.get("Content-Type"));
Assert.assertEquals("application/json", requestProps.get("Accept"));
Assert.assertEquals("test", requestProps.get("Authorization"));
Assert.assertEquals("24b9afef-3cc7-4e32-944d-f89253c1b64b", requestProps.get("X-Request-ID"));
}

private HttpHeaders mockHttpHeaders(Map<String, String> headers) {
Expand All @@ -61,7 +64,8 @@ public void testEmptyProperty(){
HttpHeaders httpHeaders = mockHttpHeaders(ImmutableMap.of(
"Content-Type", "application/json",
"Accept", "application/json",
"Authorization", ""
"Authorization", "",
"X-Request-ID", "24b9afef-3cc7-4e32-944d-f89253c1b64b"
));

RequestHeaderBuilder requestHeaderBuilder = new RequestHeaderBuilder();
Expand All @@ -70,6 +74,7 @@ public void testEmptyProperty(){
Assert.assertNotNull(requestProps);
Assert.assertEquals("application/json", requestProps.get("Content-Type"));
Assert.assertEquals("application/json", requestProps.get("Accept"));
Assert.assertEquals("24b9afef-3cc7-4e32-944d-f89253c1b64b", requestProps.get("X-Request-ID"));
Assert.assertNull( requestProps.get("Authorization"));
}

Expand All @@ -78,7 +83,9 @@ public void testMissingProperty(){
HttpHeaders httpHeaders = mockHttpHeaders(ImmutableMap.of(
"Content-Type", "application/json",
"Accept", "application/json",
"Authorization", ""));
"Authorization", "",
"X-Request-ID", "24b9afef-3cc7-4e32-944d-f89253c1b64b"
));

RequestHeaderBuilder requestHeaderBuilder = new RequestHeaderBuilder();
Map<String, String> requestProps = requestHeaderBuilder.buildRequestHeaders(
Expand All @@ -87,34 +94,39 @@ public void testMissingProperty(){
Assert.assertEquals("application/json", requestProps.get("Content-Type"));
Assert.assertEquals("application/json", requestProps.get("Accept"));
Assert.assertNull( requestProps.get("Authorization"));
Assert.assertEquals("24b9afef-3cc7-4e32-944d-f89253c1b64b", requestProps.get("X-Request-ID"));
}

@Test
public void testForwardOneHeader(){
HttpHeaders httpHeaders = mockHttpHeaders(ImmutableMap.of(
"Content-Type", "",
"Accept", "",
"Authorization", "",
"target-sr-cluster", "sr-xyz",
"some-other-header", "abc"));
Map<String, String> headers = new HashMap<>();
headers.put("Content-Type", "");
headers.put("Accept", "");
headers.put("Authorization", "");
headers.put("target-sr-cluster", "sr-xyz");
headers.put("some-other-header", "abc");
headers.put("X-Request-ID", "24b9afef-3cc7-4e32-944d-f89253c1b64b");
HttpHeaders httpHeaders = mockHttpHeaders(headers);

RequestHeaderBuilder requestHeaderBuilder = new RequestHeaderBuilder();
Map<String, String> requestProps = requestHeaderBuilder.buildRequestHeaders(
httpHeaders, Collections.singletonList("target-sr-cluster"));
Assert.assertNotNull(requestProps);
Assert.assertEquals("sr-xyz", requestProps.get("target-sr-cluster"));
Assert.assertNull(requestProps.get("some-other-header"));
Assert.assertEquals("24b9afef-3cc7-4e32-944d-f89253c1b64b", requestProps.get("X-Request-ID"));
}

@Test
public void testForwardMultipleHeaders(){
HttpHeaders httpHeaders = mockHttpHeaders(ImmutableMap.of(
"Content-Type", "",
"Accept", "",
"Authorization", "",
"target-sr-cluster", "sr-xyz",
"some-other-header", "abc"
));
Map<String, String> headers = new HashMap<>();
headers.put("Content-Type", "");
headers.put("Accept", "");
headers.put("Authorization", "");
headers.put("target-sr-cluster", "sr-xyz");
headers.put("some-other-header", "abc");
headers.put("X-Request-ID", "24b9afef-3cc7-4e32-944d-f89253c1b64b");
HttpHeaders httpHeaders = mockHttpHeaders(headers);

List<String> headersForward = ImmutableList.of("target-sr-cluster", "some-other-header");

Expand All @@ -124,35 +136,39 @@ public void testForwardMultipleHeaders(){
Assert.assertNotNull(requestProps);
Assert.assertEquals("sr-xyz", requestProps.get("target-sr-cluster"));
Assert.assertEquals("abc", requestProps.get("some-other-header"));
Assert.assertEquals("24b9afef-3cc7-4e32-944d-f89253c1b64b", requestProps.get("X-Request-ID"));
}

@Test
public void testDoNotForwardHeaders() {
HttpHeaders httpHeaders = mockHttpHeaders(ImmutableMap.of(
"Content-Type", "",
"Accept", "",
"Authorization", "",
"target-sr-cluster", "sr-xyz",
"some-other-header", "abc"
));
Map<String, String> headers = new HashMap<>();
headers.put("Content-Type", "");
headers.put("Accept", "");
headers.put("Authorization", "");
headers.put("target-sr-cluster", "sr-xyz");
headers.put("some-other-header", "abc");
headers.put("X-Request-ID", "24b9afef-3cc7-4e32-944d-f89253c1b64b");
HttpHeaders httpHeaders = mockHttpHeaders(headers);

RequestHeaderBuilder requestHeaderBuilder = new RequestHeaderBuilder();
Map<String, String> requestProps = requestHeaderBuilder.buildRequestHeaders(
httpHeaders, Collections.EMPTY_LIST);
Assert.assertNotNull(requestProps);
Assert.assertNull(requestProps.get("target-sr-cluster"));
Assert.assertNull(requestProps.get("some-other-header"));
Assert.assertEquals("24b9afef-3cc7-4e32-944d-f89253c1b64b", requestProps.get("X-Request-ID"));
}

@Test
public void testNullWhitelist() {
HttpHeaders httpHeaders = mockHttpHeaders(ImmutableMap.of(
"Content-Type", "application/json",
"Accept", "application/json",
"Authorization", "test",
"target-sr-cluster", "sr-xyz",
"some-other-header", "abc"
));
Map<String, String> headers = new HashMap<>();
headers.put("Content-Type", "application/json");
headers.put("Accept", "application/json");
headers.put("Authorization", "test");
headers.put("target-sr-cluster", "sr-xyz");
headers.put("some-other-header", "abc");
headers.put("X-Request-ID", "24b9afef-3cc7-4e32-944d-f89253c1b64b");
HttpHeaders httpHeaders = mockHttpHeaders(headers);

RequestHeaderBuilder requestHeaderBuilder = new RequestHeaderBuilder();
Map<String, String> requestProps = requestHeaderBuilder.buildRequestHeaders(
Expand All @@ -163,5 +179,6 @@ public void testNullWhitelist() {
Assert.assertEquals("test", requestProps.get("Authorization"));
Assert.assertNull(requestProps.get("target-sr-cluster"));
Assert.assertNull(requestProps.get("some-other-header"));
Assert.assertEquals("24b9afef-3cc7-4e32-944d-f89253c1b64b", requestProps.get("X-Request-ID"));
}
}

0 comments on commit 3e4e14f

Please sign in to comment.