-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid duplicating the Schema class in both the client and the server #66
Comments
RestUtils is also duplicated |
@junrao @nehanarkhede
While the structure is currently identical, the class should not be shared for these two distinct purposes - so the preferred solution to this issue is to actually split into separate classes with less ambiguous names. |
Adding some notes since I think discussion in other issues are assuming the fix for this issue is going to resolve a number of issues that have arisen as we've discussed how code is shared among the different modules. It increasingly sounds like this issue is now being treated as "Clean up the separation between the client and core modules".
|
Committed to master. |
The reason that the code is duplicated is that Schema on the server depends on Storage, which we don't want to drag into the client. We can probably refactor the code a bit to avoid the duplication.
The text was updated successfully, but these errors were encountered: