Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add key.serializer property to kafka-avro-console-producer (#935) #1246

Merged
merged 1 commit into from Dec 18, 2019
Merged

Add key.serializer property to kafka-avro-console-producer (#935) #1246

merged 1 commit into from Dec 18, 2019

Conversation

scottadav
Copy link
Contributor

Enhance kafka-avro-console-producer with support for String (non-Avro) key serializer #935

@ghost
Copy link

ghost commented Nov 26, 2019

It looks like @scottadav hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@scottadav
Copy link
Contributor Author

[clabot:check]

@ghost
Copy link

ghost commented Nov 27, 2019

@confluentinc It looks like @scottadav just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@scottadav
Copy link
Contributor Author

@rayokota Could you take a look when you get a chance? Thanks!

rayokota
rayokota reviewed Dec 18, 2019
View reviewed changes
Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @scottadav ! LGTM. Please change the base branch to master and I can merge

@scottadav scottadav changed the base branch from 5.4.x to master December 18, 2019 23:15
@scottadav
Copy link
Contributor Author

Base branch changed to master. Could you take a look now?

rayokota
rayokota approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rayokota rayokota merged commit 5bededd into confluentinc:master Dec 18, 2019
@rudi-ct rudi-ct mentioned this pull request Jan 16, 2020
Merged
@jkt628 jkt628 mentioned this pull request Feb 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayokota rayokota rayokota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scottadav @rayokota