Reflection serde #1281
Merged
Reflection serde #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default constructor allows the SerDe to be used as default serde in KStreams config.
…during construction
|
It looks like @piotrsmolinski hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
rayokota
reviewed
Jan 8, 2020
avro-serializer/src/main/java/io/confluent/kafka/serializers/AbstractKafkaAvroDeserializer.java
Outdated
Show resolved
Hide resolved
avro-serializer/src/main/java/io/confluent/kafka/serializers/AbstractKafkaAvroDeserializer.java
Outdated
Show resolved
Hide resolved
avro-serde/src/main/java/io/confluent/kafka/streams/serdes/avro/ReflectionAvroDeserializer.java
Show resolved
Hide resolved
avro-serde/src/main/java/io/confluent/kafka/streams/serdes/avro/ReflectionAvroDeserializer.java
Show resolved
Hide resolved
|
[clabot:check] |
|
@confluentinc It looks like @piotrsmolinski just signed our Contributor License Agreement. 👍 Always at your service, clabot |
|
@piotrsmolinski , the test |
The failure in testVersionMaintained was caused by caching the schema for given name. In case of GenericDatumReader the schema is as it comes from the serialized record. This means if the schema evolves, there could be multiple representations of the same avro record.
rayokota
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch adds dynamic resolution of the Avro schema when Reflection API is used.
It solves one of the limitations of the initial implementation of the feature. The change allows to use the Reflection API deserialization in the following scenarios: