Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding an NPE check for permanent delete #1654

Merged
merged 2 commits into from Oct 19, 2020
Merged

Adding an NPE check for permanent delete #1654

merged 2 commits into from Oct 19, 2020

Conversation

maverick64
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Oct 17, 2020

@confluentinc It looks like @maverick64 just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@rayokota
Copy link
Member

Another check should be added on line 580 where we also throw the same exception

rayokota
rayokota approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maverick64 maverick64 merged commit 398a1a2 into confluentinc:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayokota rayokota rayokota approved these changes

@dragosvictor dragosvictor dragosvictor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maverick64 @rayokota @dragosvictor