Add kafkastore.topic.skip.validation configurations option #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @CGA1123 hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
CGA1123
changed the title
|
[clabot:check] |
|
@confluentinc It looks like @CGA1123 just signed our Contributor License Agreement. 👍 Always at your service, clabot |
CGA1123
commented
Jan 10, 2021
core/src/main/java/io/confluent/kafka/schemaregistry/rest/SchemaRegistryConfig.java
Outdated
Show resolved
Hide resolved
Adds the `kafkastore.topic.verify` option (defaulting to `true` to preserve current behaviour). This options controls whether schema-registry performs verification and auto-creation of topics on boot. Disabling this functionality is required in environments where clients do not have the `DescribeConfigs` or where topic auto creation is not supported. For example, this is required in order to run the schema-registry with Heroku's managed Apache Kafka service (See [Kafka on Heroku ACLs]). [Kafka on Heroku ACLs]: https://devcenter.heroku.com/articles/kafka-on-heroku#understanding-acls Signed-off-by: Christian Gregg <christian@bissy.io>
CGA1123
changed the title
Adds the `kafkastore.topic.skip.validation` option (defaulting to `false` to preserve current behaviour). This options controls whether schema-registry performs validation and auto-creation of the schema topics on boot. Enabling this option is required in environments where clients do not have the `DescribeConfigs` or where topic auto creation is not supported. For example, this is required in order to run the schema-registry with Heroku's managed Apache Kafka service (See [Kafka on Heroku ACLs]). [Kafka on Heroku ACLs]: https://devcenter.heroku.com/articles/kafka-on-heroku#understanding-acls Signed-off-by: Christian Gregg <christian@bissy.io>
|
@rayokota Updated! |
|
Thanks @CGA1123 ! Here are some Checkstyle issues to fix: |
|
Thanks @rayokota -- I was having some issues accessing Jenkins yesterday, was 404ing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
kafkastore.topic.skip.validationoption (defaulting tofalsetopreserve current behaviour). This options controls whether
schema-registry performs validation and auto-creation of the schema
topics on boot.
Enabling this option is required in environments where clients do not
have the
DescribeConfigsor where topic auto creation is notsupported.
For example, this is required in order to run the schema-registry with
Heroku's managed Apache Kafka service (See Kafka on Heroku ACLs).
Signed-off-by: Christian Gregg christian@bissy.io