Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DGS-2989 Update function return type due to changes in parent class #2172

Merged
merged 1 commit into from Feb 10, 2022

Conversation

sanjay-awatramani
Copy link
Member

Updated return type of onJoinPrepare due to changes in parent class.
Refer below snippets for guidance on the return type
`* @return true If onJoinPrepare async commit succeeded, false otherwise


    // return true when
     // 1. future is null, which means no commit request sent, so it is still considered completed
     // 2. offset commit completed
     // 3. offset commit failed with non-retriable exception`

source: https://github.com/apache/kafka/pull/11340/files
Also refer https://github.com/apache/kafka/pull/11340/files#diff-9075bf1ce4e8d878d16f25add001986e3e319cd5ce93290e4f10e4fd60e60155L221 for another example of a usage similar to ours

@dragosvictor dragosvictor requested a review from a team February 10, 2022 15:41
Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sanjay-awatramani , LGTM

Copy link

@guozhangwang guozhangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert on SR, but just for the API changes itself LGTM.

Copy link
Contributor

@dragosvictor dragosvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided it passes the build. (Triggered a new one here after merging #2173).

@dragosvictor dragosvictor merged commit b10e063 into master Feb 10, 2022
@sanjay-awatramani sanjay-awatramani deleted the dgs-2989 branch February 11, 2022 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants