Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata/rules to schema format #2398

Merged
merged 4 commits into from Oct 17, 2022
Merged

Add metadata/rules to schema format #2398

merged 4 commits into from Oct 17, 2022

Conversation

rayokota
Copy link
Member

@rayokota rayokota commented Oct 7, 2022 •
edited

Add new classes and fields to add metadata/rules to schema format

@rayokota rayokota requested a review from a team as a code owner October 7, 2022 15:56
@rayokota rayokota force-pushed the schema-rules branch 3 times, most recently from 82e2d3b to ca2623f Compare October 12, 2022 20:18
xiaoyali97
xiaoyali97 approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@xiaoyali97 xiaoyali97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rayokota, left a minor question, otherwise LGTM.

client/src/main/java/io/confluent/kafka/schemaregistry/client/rest/entities/Rule.java Outdated Show resolved Hide resolved
@rayokota rayokota merged commit 481afcd into confluentinc:master Oct 17, 2022
@rayokota rayokota deleted the schema-rules branch October 17, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoyali97 xiaoyali97 xiaoyali97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rayokota @xiaoyali97