Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DGS-6701 Fix getSchemaById to match subject if passed #2590

Merged
merged 3 commits into from Apr 5, 2023

Conversation

rayokota
Copy link
Member

@rayokota rayokota commented Apr 4, 2023

We ensure the subject name is matched when calling getSchemaById.

For calls to getSchemaById that don't care about the subject name matching (but only the context), we pass a qualified context with no subject name.

This is a fix to #2443

@rayokota rayokota changed the title DGS-6701 Fix getSchemaById to match subject DGS-6701 Fix getSchemaById to match subject if passed Apr 4, 2023
Copy link
Member

@xiaoyali97 xiaoyali97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rayokota rayokota merged commit f94ccc2 into confluentinc:7.0.x Apr 5, 2023
2 of 3 checks passed
@rayokota rayokota deleted the DGS-6701 branch April 5, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants