DGS-7103 Optimize instantiation of lists of schemas #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericwush
reviewed
Apr 24, 2023
core/src/main/java/io/confluent/kafka/schemaregistry/storage/LazyParsedSchemaHolder.java
Show resolved
Hide resolved
ericwush
approved these changes
May 5, 2023
| int newVersion = MIN_VERSION; | ||
| for (SchemaValue schemaValue : allVersions) { |
There was a problem hiding this comment.
Just for my understanding, this is the root cause for the OOM since all the schema versions are referenced and can only be potentially GC'ed after this method. Now SchemaKey is used which itself has a smaller memory footprint and SchemaValues can be GC'ed even in middle of the call due to the use of SoftReference. Is this correct?
There was a problem hiding this comment.
Yes you are correct. Plus we explicitly call schemaHolder.clear to release references to the SchemaValue instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various memory optimizations:
List<ParsedSchemaHolder>instead ofList<ParsedSchema>. This is to allow the schema to be parsed lazily.List<SchemaKey>instead ofList<Schema>orList<SchemaValue>, since keys use less memory/schemasendpoint, add config params forschema.search.default.limitandschema.search.max.limitto limit number of schemas retrieved in memory, which both default to 1000