Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DGS-7289 Adding CustomBearerAuthCredentialProvider #2635

Merged
merged 5 commits into from Jun 2, 2023
Merged

DGS-7289 Adding CustomBearerAuthCredentialProvider #2635

merged 5 commits into from Jun 2, 2023

Conversation

varunpv
Copy link
Member

@varunpv varunpv commented May 10, 2023 •
edited

Introducing CustomBearerAuthCredentialProvider to make SR client extensible for custom token provider implementation.
Users can implement their own concrete Implementation of the BearerAuthCredentialProvider Interface and plug into sr using this provider.
The user would have to give the following configs.

bearer.auth.credentials.source=CUSTOM
bearer.auth.custom.token.provider.class=<Fully Qualified class name of custom Implementation>
bearer.auth.logical.cluster=<lsrc-xxxxx> #optional, needed for Confluent cloud SR
bearer.auth.identity.pool.id=<pood Id> #optional, needed for Confluent cloud SR

@varunpv varunpv changed the title * Adding CustomTokenCredentialProvider to make SR client extensible f… DGS-7289 Adding CustomTokenCredentialProvider May 10, 2023
@varunpv varunpv changed the title DGS-7289 Adding CustomTokenCredentialProvider DGS-7289 Adding CustomBearerAuthCredentialProvider May 24, 2023
@varunpv varunpv changed the base branch from master to 7.3.x May 24, 2023 04:55
@varunpv varunpv marked this pull request as ready for review May 24, 2023 07:37
@varunpv varunpv requested a review from a team as a code owner May 24, 2023 07:37
rayokota
rayokota reviewed May 30, 2023
View reviewed changes
Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @varunpv , left a minor comment. Also, should we change the base to 7.4.x instead of 7.3.x?

client/src/main/java/io/confluent/kafka/schemaregistry/client/SchemaRegistryClientConfig.java Outdated Show resolved Hide resolved
client/src/main/java/io/confluent/kafka/schemaregistry/client/SchemaRegistryClientConfig.java Outdated Show resolved Hide resolved
@varunpv
Copy link
Member Author

varunpv commented Jun 1, 2023

Thanks @varunpv , left a minor comment. Also, should we change the base to 7.4.x instead of 7.3.x?

@rayokota A customer wanted this and they are using 7.3 and It can go in the next patch release.

rayokota
rayokota approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunpv varunpv merged commit 59dee8e into 7.3.x Jun 2, 2023
3 checks passed
@varunpv varunpv deleted the DGS-7289 branch June 2, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayokota rayokota rayokota approved these changes

@xiaoyali97 xiaoyali97 Awaiting requested review from xiaoyali97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@varunpv @rayokota