Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DGS-7407 Fix issues for numeric types in CEL_FIELD exprs #2645

Merged
merged 11 commits into from May 22, 2023

Conversation

rayokota
Copy link
Member

@rayokota rayokota commented May 20, 2023

Fix issues and add tests for numeric types in CEL_FIELD exprs, esp Protobuf and JSON Schema
Better handling when value is null in CEL exprs.
Clean up log messages by using placeholder syntax instead of string concatenation.

@rayokota rayokota requested a review from a team as a code owner May 20, 2023 03:22
@rayokota rayokota changed the title Better handling when value is null in CEL exprs Add tests for primitives in CEL_FIELD exprs May 20, 2023
Copy link
Member

@xiaoyali97 xiaoyali97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rayokota , LGTM.

@rayokota rayokota merged commit 3f828c8 into confluentinc:7.4.x May 22, 2023
3 checks passed
@rayokota rayokota deleted the fix-cel-null branch May 22, 2023 19:07
@rayokota rayokota changed the title Add tests for primitives in CEL_FIELD exprs Fix issues for primitives in CEL_FIELD exprs May 23, 2023
@rayokota rayokota changed the title Fix issues for primitives in CEL_FIELD exprs DGS-7407 Fix issues for primitives in CEL_FIELD exprs May 23, 2023
@rayokota rayokota changed the title DGS-7407 Fix issues for primitives in CEL_FIELD exprs DGS-7407 Fix issues for numeric types in CEL_FIELD exprs May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants