Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DGS-7422 Optimization: omit compat check during IMPORT #2647

Merged
merged 3 commits into from May 24, 2023
Merged

DGS-7422 Optimization: omit compat check during IMPORT #2647

merged 3 commits into from May 24, 2023

Conversation

rayokota
Copy link
Member

@rayokota rayokota commented May 24, 2023 •
edited

Omit the compat check during IMPORT mode. This avoids situations where Avro throws an AvroRuntimeException, which halts import.

yao-gu
yao-gu approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@yao-gu yao-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you. Left one question.

core/src/main/java/io/confluent/kafka/schemaregistry/storage/KafkaSchemaRegistry.java Show resolved Hide resolved
@rayokota rayokota merged commit f1fc294 into confluentinc:7.0.x May 24, 2023
3 checks passed
@rayokota rayokota deleted the DGS-7422 branch May 24, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-gu yao-gu yao-gu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rayokota @yao-gu