Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DGS-7430 Add auto.flush config for DlqAction #2652

Merged
merged 2 commits into from May 30, 2023

Conversation

rayokota
Copy link
Member

Add auto.flush config for DlqAction

@rayokota rayokota requested a review from a team as a code owner May 26, 2023 22:46
Copy link
Member

@xiaoyali97 xiaoyali97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -54,6 +54,7 @@ public class DlqAction implements RuleAction {
public static final String RULE_EXCEPTION = HEADER_PREFIX + "exception";

public static final String TOPIC = "topic";
public static final String AUTO_FLUSH = "auto.flush";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call it dlq.auto.flush?

Suggested change
public static final String AUTO_FLUSH = "auto.flush";
public static final String AUTO_FLUSH = "dlq.auto.flush";

@rayokota rayokota merged commit 975f923 into confluentinc:7.4.x May 30, 2023
3 checks passed
@rayokota rayokota deleted the DGS-7430 branch May 30, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants