Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR Added another constructor to DekRegistryConfig #2744

Merged
merged 1 commit into from Aug 29, 2023
Merged

MINOR Added another constructor to DekRegistryConfig #2744

merged 1 commit into from Aug 29, 2023

Conversation

MINHN98
Copy link
Member

@MINHN98 MINHN98 commented Aug 29, 2023

So i can extend DekRegistryConfig

@MINHN98 MINHN98 requested a review from a team as a code owner August 29, 2023 00:31
@cla-assistant
Copy link

cla-assistant bot commented Aug 29, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Aug 29, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@MINHN98 MINHN98 changed the title Added another contructor to DekRegistryConfig MINOR Added another contructor to DekRegistryConfig Aug 29, 2023
@MINHN98 MINHN98 requested a review from rayokota August 29, 2023 00:32
rayokota
rayokota approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MINHN98 MINHN98 changed the title MINOR Added another contructor to DekRegistryConfig MINOR Added another constructor to DekRegistryConfig Aug 29, 2023
@MINHN98 MINHN98 merged commit 03e523a into 7.4.x Aug 29, 2023
3 of 4 checks passed
@MINHN98 MINHN98 deleted the mnguyen/dek-reg-config branch August 29, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayokota rayokota rayokota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MINHN98 @rayokota