Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DGS-8553: Updated create and delete DEK Registry API documented names #2772

Merged
merged 1 commit into from Sep 25, 2023
Merged

DGS-8553: Updated create and delete DEK Registry API documented names #2772

merged 1 commit into from Sep 25, 2023

Conversation

MINHN98
Copy link
Member

@MINHN98 MINHN98 commented Sep 25, 2023 •
edited

DocumentedName Changes

  • deleteKek -> deregisterKek
  • createKek -> registerKek
  • deleteDek -> deregisterDek
  • createDek -> registerDek

@MINHN98 MINHN98 requested a review from a team as a code owner September 25, 2023 17:36
@cla-assistant
Copy link

cla-assistant bot commented Sep 25, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Sep 25, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

akhileshm1
akhileshm1 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@akhileshm1 akhileshm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @MINHN98 . LGTM.

rayokota
rayokota approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MINHN98 , LGTM

@MINHN98 MINHN98 merged commit b0fb859 into 7.4.x Sep 25, 2023
3 of 4 checks passed
@MINHN98 MINHN98 deleted the mnguyen/DGS-8553 branch September 25, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayokota rayokota rayokota approved these changes

@akhileshm1 akhileshm1 akhileshm1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MINHN98 @rayokota @akhileshm1