DGS-8542 Add support for JSON Schema Draft 2020-12 #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayokota
force-pushed
the
json-schema-2020-12-master
branch
from
1f579a2
to
e21611d
Compare
akhileshm1
approved these changes
Oct 9, 2023
...hema-provider/src/main/java/io/confluent/kafka/schemaregistry/json/SpecificationVersion.java
Outdated
Show resolved
Hide resolved
...hema-provider/src/main/java/io/confluent/kafka/schemaregistry/json/SpecificationVersion.java
Show resolved
Hide resolved
Comment on lines
+101
to
+106
| BigDecimal updateMultipleOf = update.getMultipleOf() != null | ||
| ? new BigDecimal(update.getMultipleOf().toString()) | ||
| : null; | ||
| BigDecimal originalMultipleOf = original.getMultipleOf() != null | ||
| ? new BigDecimal(original.getMultipleOf().toString()) | ||
| : null; |
There was a problem hiding this comment.
for my own understanding, why are we doing the conversion to BigDecimal here?
There was a problem hiding this comment.
We convert to BigDecimal so we can accurately tell if the new multipleOf value is a multiple of the old multipleOf value when the values are decimals. For example, to tell if 0.002 is a multiple of 0.001. Otherwise this ends being a modulus of floating point numbers, which is not always accurate.
...r/src/main/java/io/confluent/kafka/schemaregistry/json/jackson/JsonSkemaArraySerializer.java
Show resolved
Hide resolved
.../src/main/java/io/confluent/kafka/schemaregistry/json/jackson/JsonSkemaObjectSerializer.java
Show resolved
Hide resolved
|
hi! when is the next release? I see a release from a few days before this merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for JSON Schema Draft 2020-12.
We use the json-skema library for draft 2020-12 and the everit library for previous drafts. When iterating over a schema, we use the object model from everit since it is easier to work with. We therefore translate from the json-skema classes to the everit classes whenever we need an object model to traverse.
Fixes #2534 , fixes #2580