Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DGS-8901 Ensure logical type config is applied to Reflect/Specific Avro data types #2805

Merged
merged 5 commits into from Oct 24, 2023
Merged

DGS-8901 Ensure logical type config is applied to Reflect/Specific Avro data types #2805

merged 5 commits into from Oct 24, 2023

Conversation

rayokota
Copy link
Member

@rayokota rayokota commented Oct 23, 2023 •
edited

If the user specified avro.use.logical.type.converters=true, it was only being used by Generic Avro types, and not by Reflect/Specific Avro types.

Fixes #2803

@rayokota rayokota requested a review from a team as a code owner October 23, 2023 21:22
@rayokota rayokota changed the title Use GenericData from getGenericData to handle Avro logical types DGS-8901 Ensure logical type config is applied to Reflect/Specific Avro data types Oct 23, 2023
@rayokota rayokota merged commit 1c390a0 into confluentinc:7.4.x Oct 24, 2023
4 checks passed
@rayokota rayokota deleted the add-conversions branch October 24, 2023 20:27
@matdryz
Copy link

matdryz commented Nov 8, 2023

that breaks specific avro types, if avro.use.logical.type.converters=false data would be set to SpecificData.getForSchema(schema), now it's set to SpecificData.get()

Also avro.use.logical.type.converters is supposed to only work for generic records according to documentation: https://github.com/confluentinc/schema-registry/blob/master/avro-serializer/src/main/java/io/confluent/kafka/serializers/KafkaAvroSerializerConfig.java

@rayokota
Copy link
Member Author

rayokota commented Nov 8, 2023

Thanks @matdryz , I'll take a look

@rayokota
Copy link
Member Author

rayokota commented Nov 8, 2023 •
edited

Fixed by #2835

@reneveyj reneveyj mentioned this pull request Mar 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyanas karthikeyanas karthikeyanas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rayokota @matdryz @karthikeyanas