Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix packaging of kafka-connect-avro-converter #2811

Merged
merged 1 commit into from Oct 31, 2023
Merged

fix packaging of kafka-connect-avro-converter #2811

merged 1 commit into from Oct 31, 2023

Conversation

munkyboy
Copy link
Contributor

The avro-converter project depends on avro-serializer which depends on guava. For some reason, marking it as a test dependency omits it as a transitive compile dependency.

This fixes issue #2804

@munkyboy
fix packaging of kafka-connect-avro-converter
2650dd1 
The avro-converter project depends on avro-serializer which depends on
guava. For some reason, marking it as a test dependency omits it as a
transitive compile dependency.

This fixes issue confluentinc#2804
@munkyboy munkyboy requested a review from a team as a code owner October 29, 2023 19:17
@cla-assistant
Copy link

cla-assistant bot commented Oct 29, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Oct 29, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rayokota
Copy link
Member

Thanks @munkyboy , can you sign the CLA?

rayokota
rayokota approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @munkyboy , LGTM

@rayokota rayokota merged commit 3a8e1e8 into confluentinc:master Oct 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayokota rayokota rayokota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@munkyboy @rayokota