APIs changed to refer to subjects. Retrieval by globally unique schema id #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded the ability to assign globally unique schema id on the master and retrieve schemas using ids 3. Unit tests need to be modified
…ves to be too memory intensive during performance testing, we can change it to a memory mapped index constructed from scratch during bootstrap 2. All tests pass. Changed tests to validate schemas based on ids. Also included tests that get the same schema using id and subject,version
This was referenced Dec 30, 2014
|
@junrao Best if you review this pull request |
| {"schema":"Hello World"}' | ||
|
|
||
| curl -v -H "Content-Type: application/vnd.schemaregistry.v1+json" -X POST -i http://localhost:8080/subjects/Kafka,key/versions -d ' | ||
| {"schema":"Kafka"}' | ||
|
|
||
| 5. List all topics |
…nly unique identifier for a schema is the subject and the version
|
@junrao Addressed your review comments. I'm ready to merge unless you want to take another look. |
|
|
||
| 8. Get a particular schema using it's id (as returned by the register request) | ||
| curl -v -H "Content-Type: application/vnd.schemaregistry.v1+json" -X GET http://localhost:8080/subjects/0 | ||
| curl -v -H "Content-Type: application/vnd.schemaregistry.v1+json" -X GET http://localhost:8080/subjects/1 |
There was a problem hiding this comment.
Will remove during the push
|
Thanks for the review. Pushed to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29