New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for basic auth in maven schema registry plugin #907
Conversation
It looks like @rhysmccaig hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
[clabot:check] |
@confluentinc It looks like @rhysmccaig just signed our Contributor License Agreement. 👍 Always at your service, clabot |
Successfully tested the following configurations after making this change:
|
@rhysmccaig thanks a lot for getting to this. This will be super useful. Since the plugin is likely to be used from CI/CD and the credentials would also most likely be injected via CI tools, I would think that we don't have to expose the concept of |
@mageshn I had considered that, but also wondered if perhaps it makes sense to keep the URL option in case there are multiple schema registries to push the schemas to/validate against? I'm happy with either approach. Let me know what you think and I can push the changes if required. |
@rhysmccaig you can only configure a plugin to go against a single SR cluster. So, I think it probably makes sense to simplify the configuration for this. |
@mageshn ahh, fair enough. no worries - ill make the changes and push shortly |
@mageshn should be good to go 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @rhysmccaig for this contribution.
I can't figure out how to get this repo to build locally, but this is my best guess at a patch that will support basic auth in the maven schema registry plugin. Would be great to get thoughts from anyone with better knowledge of the repo.Edit: Got this building and tested. Its ready to merge if a committer can take a look. See comment below.