Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

Update sample-project.md #1

Closed
wants to merge 1 commit into from
Closed

Conversation

codyaray
Copy link
Member

Just some feedback from a quick review.

  1. Make the ccloud CLI instructions match the CCloud UI instructions (i.e., only for service account id instead of all 3)
  2. Simplify the CLI output with a grep command
  3. Add more detail to the UI for creating cluster API Keys
  4. Make variables required (so that they're prompted for if not provided)
  5. Don't mark var.kafka_api_key as sensitive (since the key id can be logged, but the secret can't)
  6. Fix guide to document how to pass variable values (as terraform.tfvars for now, but with disclaimer)

@codyaray codyaray requested review from linouk23 and a team September 28, 2021 03:27
@codyaray codyaray closed this Sep 28, 2021
@codyaray codyaray deleted the update-sample-project-guide branch September 28, 2021 03:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant