Fix falsy string and int query values #189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#133 and #177 fixed this for input objects, but not query values.
Sending a 0 value on an int with min constraint or an empty string on a string with minLength constraint would skip validation previously.
Making the values non-nullable doesn't help, and using defaults (in a resolver) can help, but not for all cases. For instance for an auth query you don't want to give a username a default and cause db queries for something that should be failing validation.
See #187 for an example of the problem.