-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If I understand your code correctly... #3
Comments
Hi there! You are right! Going by meaning and to avoid errors on datasets with similar layout that are not the In-Shop dataset, it should be However as a sidenote: This does not change any previously computed results, the numerical results are computed correctly (just checked again), and the qualitative results are still showing the closest gallery images given a query image, its just the random selection of query images to visualize that could change. Thanks for pointing that out :). |
Thanks for the confirmation. In my case the len(query_feature_matrix_all)
is less than the len(gallery_feature_matrix_all), so I need to change it.
Best,
Cheng
…On Thu, Sep 19, 2019 at 4:40 PM Karsten Roth ***@***.***> wrote:
Hi there!
You are right! Going by meaning and to avoid errors on datasets with
similar layout that are not the In-Shop dataset, it should be
len(query_feature_matrix_all). I will adjust this.
However as a sidenote: This does not change any previously computed
results, the numerical results are computed correctly (just checked again),
and the qualitative results are still showing the closest gallery images
given a query image, its just the random selection of query images to
visualize that could change.
Thanks for pointing that out :).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=AJKLC6CCW7CVOQ2B5KGBDJDQKQEYDA5CNFSM4IYRA2J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7FD47Y#issuecomment-533347967>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJKLC6D3YW4T7LPPP42NSHTQKQEYDANCNFSM4IYRA2JQ>
.
|
Hello sir,
In the file 'auxiliaries.py', line 391:
sample_idxs = np.random.choice(np.arange(len(gallery_feature_matrix_all)), n_image_samples)
If I understand your code correctly, should 'gallery_feature_matrix_all' be 'query_feature_matrix_all'?
Thanks
The text was updated successfully, but these errors were encountered: