bug fixes for iOS

conghaonet · Nov 6, 2019 · 9c4ca93 · 9c4ca93
1 parent 41177fe
commit 9c4ca93
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/lib/generated/i18n.dart b/lib/generated/i18n.dart
@@ -67,6 +67,7 @@ class S implements WidgetsLocalizations {
   String get myRepos => "My repos";
   String get news => "News";
   String get noMoreData => "No more data";
+  String get notYetPublishedToTheAppStore => "Not yet published to the App Store.";
   String get notifications => "Notifications";
   String get oopsWrong => "Oops wrong!";
   String get open => "Open";
@@ -220,6 +221,8 @@ class $zh_CN extends S {
   @override
   String get share => "分享";
   @override
+  String get notYetPublishedToTheAppStore => "尚未发布到 App Store";
+  @override
   String get email => "邮箱";
   @override
   String get orgUppercase => "组织";

diff --git a/lib/pages/about_page.dart b/lib/pages/about_page.dart
@@ -1,8 +1,10 @@
+import 'dart:io';
 import 'package:flutter/material.dart';
 import 'package:githao/generated/i18n.dart';
 import 'package:githao/pages/profile_page.dart';
 import 'package:githao/pages/repo_home_page.dart';
 import 'package:githao/routes/profile_page_args.dart';
+import 'package:githao/utils/util.dart';
 import 'package:launch_review/launch_review.dart';
 import 'package:package_info/package_info.dart';
 import 'package:share/share.dart';
@@ -111,7 +113,11 @@ class _AboutPageState extends State<AboutPage> {
                 title: Text(S.current.rateOrCommentInMarket),
                 trailing: Icon(Icons.keyboard_arrow_right),
                 onTap: () {
-                  LaunchReview.launch();
+                  if(Platform.isAndroid) {
+                    LaunchReview.launch();
+                  } else {
+                    Util.showToast(S.current.notYetPublishedToTheAppStore);
+                  }
                 },
               ),
             ],

diff --git a/res/values/strings_en.arb b/res/values/strings_en.arb
@@ -100,5 +100,6 @@
   "watched": "Watched",
   "unwatch": "Unwatch",
   "unwatched": "Unwatched",
-  "forkedToViewTheParentRepository": "Forked, to view the parent repository."
+  "forkedToViewTheParentRepository": "Forked, to view the parent repository.",
+  "notYetPublishedToTheAppStore": "Not yet published to the App Store."
 }
diff --git a/res/values/strings_zh_CN.arb b/res/values/strings_zh_CN.arb
@@ -100,5 +100,6 @@
   "watched": "已订阅",
   "unwatch": "取消订阅",
   "unwatched": "已取消订阅",
-  "forkedToViewTheParentRepository": "Forked 查看父版本库"
+  "forkedToViewTheParentRepository": "Forked 查看父版本库",
+  "notYetPublishedToTheAppStore": "尚未发布到 App Store"
 }