fix: passing version from version tag #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using the version tags we can choice when to build a new release. However the `ldflags` where not passed correctly.
Nr18
added a commit
that referenced
this pull request
Sep 20, 2023
**Issue #, if available:** Use a single command to rotate your AWS CLI credentials. **Checklist** <!--- Leave unchecked if your change doesn't seem to apply --> * [x] Update tests * [x] Update docs * [x] PR title follows [conventional commit semantics](https://www.conventionalcommits.org/en/v1.0.0-beta.2/#commit-message-for-a-fix-using-an-optional-issue-number) By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. fix: passing version from version tag (#5) **Issue #, if available:** By using the version tags we can choice when to build a new release. However the `ldflags` where not passed correctly. **Checklist** <!--- Leave unchecked if your change doesn't seem to apply --> * [ ] Update tests * [ ] Update docs * [x] PR title follows [conventional commit semantics](https://www.conventionalcommits.org/en/v1.0.0-beta.2/#commit-message-for-a-fix-using-an-optional-issue-number) By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. fix: use environment variable for passing the version fix: patching of version fix: rely on the default ldflags chore: add brew tap for homebrew support fix: remove deprecated tap key word and use correct name fix: use the access token for accessing the repository fix: use access token in the workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By using the version tags we can choice when to build a new release. However the
ldflagswhere not passed correctly.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.