This repository has been archived by the owner on Apr 12, 2021. It is now read-only.
Improve error handling when getting controller info #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain failures to get controller info were returning None for the info instead of raising an exception. This should raise the exception more consistently and provide better diagnostic information. Fixes #946
|
A point to note, I was able to reproduce this by stopping the controller container in lxd, which caused the UI to hang and when I hit |
adam-stokes
approved these changes
Jun 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain failures to get controller info were returning
Nonefor the info instead of raising an exception. This should raise the exception more consistently and provide better diagnostic information.Fixes #946