Disable ClientHandlerThread debug logs #705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…or the client handler thread logging
jamescoverdale
force-pushed
the
disable_client_handler_debug_logs
branch
from
3579a6f
to
c283332
Compare
|
Good idea, when to merge it? |
|
@gbirchmeier any chance of getting this merged? |
jamescoverdale
force-pushed
the
disable_client_handler_debug_logs
branch
from
fb8fb88
to
c283332
Compare
Ryujose
approved these changes
Dec 5, 2021
|
I'm going to put this in the next release, hopefully in the next month or two. Apologies for letting this one sit so long. |
|
expecting |
|
I'm working on an alternate solution, begun in #830 which so far eliminates the Debug log for good and (temporarily) writes those logs to console. I'm going to route those logs to something smarter, though I haven't totally decided how that will work yet. (Got a few conflicting ideas in my head, need to decide which is best.) There are some errors that should be loggable, but not in the hacky way that Debug log works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a config flag that disables the creation of ClientHandlerThread debug logs by using a null logger if enabled.
Fixes: #684