Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectBot theme (toolbar, status bar, accent color etc.) does not reflect colors of ConnectBot logo #167

Closed
wp9015362 opened this issue Aug 31, 2015 · 14 comments
Assignees
Labels

Comments

@wp9015362
Copy link

Hello,

currently the ConnectBot theme does not reflect the colors of the ConnectBot logo:

Image

But I think it should.

Could you please make the ConnectBot theme (toolbar, status bar, accent color etc.) make reflect the colors of the ConnectBot logo, as described in the Google Material Design guidelines over there:

https://www.google.com/design/spec/style/color.html#color-ui-color-application

?

Regards

@kruton
Copy link
Member

kruton commented Sep 12, 2015

Started this in an upcoming pull request.
material-cb

@wp9015362
Copy link
Author

@kruton commented in #198 (comment) :

@jklein24 @bengolds I'm going to submit this, but I'm open to color palette changes or whatever.

Thank you.

But (no offence):

You have set the primary/dark primary colors to cyan (#00BCD4 / #0097A7).

Cyan is not part of the ConnectBot logo/"brand".

The frame around the ConnectBot logo is rather light blue or blue (which would also be available from the Google Material Design Color Palette).

But the light blue and blue colors in the Google Material Design Color Palette also do not match the light blue color of the frame around the ConnectBot logo.

I have submitted an issue for it now, see:

#201

Also, you have set the accent color to deep orange (#F4511E).

Orange is not part of the ConnectBot logo/"brand" either and it does not go well with cyan IMHO (and also would not go well with light blue either IMHO).

The accent color should not be orange IMHO.

I also noticed that the green indicator in the host list, which shows that the host is connected is #99CC00.

#99CC00 is not part of the Google Material Design Color Palette.

Maybe it would make sense to make that indicator use a green color (connected) and red color (disconnected) which is part of the Google Material Design Color Palette.

I've also submitted an issue for that now, see:

#202

Regards

@jklein24
Copy link
Collaborator

+cc @khorimoto

@jklein24
Copy link
Collaborator

https://www.materialpalette.com/ is pretty helpful for this fyi

@khorimoto-zz
Copy link
Collaborator

I'll take this on.

@kruton kruton assigned kruton and khorimoto-zz and unassigned kruton Sep 14, 2015
@kruton kruton added the ux label Sep 14, 2015
@jklein24
Copy link
Collaborator

Could also be a good starter bug for @rhansby

@wp9015362
Copy link
Author

Shouldn't it be reopened then 😉?

@wp9015362
Copy link
Author

PS:

@khorimoto / @rhansby :

It would be nice if you could also add a light theme while being at it, as requested in:

#163

That would be much appreciated.

Regards

@rhansby
Copy link
Collaborator

rhansby commented Sep 15, 2015

I'm taking this instead of @khorimoto.

@wp9015362, what would you suggest instead for the accent color? (instead of the deep orange). As I see it, deep orange is complimentary to cyan or light blue, making it a good choice.

@wp9015362
Copy link
Author

@rhansby wrote:

@wp9015362, what would you suggest instead for the accent color? (instead of the deep orange). As I see it, deep orange is complimentary to cyan or light blue, making it a good choice.

Well, you might have a point in regards to the complementary color.

I played a bit around with some blue (blue and light blue) and orange (orange and deep orange) colors in Amaze File Manager. In Amaze File Manager, the primary and accent colors can be configured by the user (it let's you choose between some specific predefined colors). As you can see, it suddenly all starts to look better once you look at it with a light theme 😉, some screenshots:

Primary: Blue / Accent: Orange / Theme: Light

Image

Primary: Light Blue / Accent: Orange / Theme: Light

Image

Primary: Blue / Accent: Deep Orange / Theme: Light

Image

Primary: Light Blue / Accent: Deep Orange / Theme: Light

Image

But it doesn't look too bad with a dark theme either, some screenshots:

Primary: Blue / Accent: Orange / Theme: Dark

Image

Primary: Light Blue / Accent: Orange / Theme: Dark

Image

Primary: Blue / Accent: Deep Orange / Theme: Dark

Image

Primary: Light Blue / Accent: Deep Orange / Theme: Dark

Image

One thing I can already conclude from having played around with those colors in Amaze File Manager is, that (IMHO) orange looks better than deep orange as accent color. What do you think?

I'm not really decided between the blue and light blue color though. But I guess light blue would probably fit better with the ConnectBot logo? On the other hand, it might be a bit too much "in your face".

Not sure.

Speaking of decision: After all, maybe it wouldn't be too bad of an idea to let the user chose the primary and accent colors himself, just like in Amaze File Manager?

Regards

@wp9015362
Copy link
Author

@rhansby :

PS:

Screw what I just said and screw orange 😉. I've played some more in Amaze File Manager. This time with cyan and blue / light blue and with teal and blue / light blue.

Without orange it looks much better and actually fits to the colors of the ConnectBot logo.

Some screenshots:

Primary: Cyan / Accent: Blue / Theme: Light

Image

Primary: Cyan / Accent: Light Blue/ Theme: Light

Image

Primary: Teal / Accent: Blue / Theme: Light

Image

Primary: Teal / Accent: Light Blue / Theme: Light

Image

Primary: Cyan / Accent: Blue / Theme: Dark

Image

Primary: Cyan / Accent: Light Blue / Theme: Dark

Image

Primary: Teal / Accent: Blue / Theme: Dark

Image

Primary: Teal / Accent: Light Blue / Theme: Dark

Image

I think it looks much better like that and without orange.

What do you think?

Regards

@wp9015362
Copy link
Author

@rhansby :

I am just wondering:

Is this still undecided / being worked on?

As far as I am concerned, the accent color really should not be orange nor deep orange (it looks really ugly IMHO and does not fit the ConnectBot logo at all).

As shown on the example screenshots above, I think blue or light blue look way better as an accent color (with cyan as the primary color).

Regards

@rhansby
Copy link
Collaborator

rhansby commented Sep 23, 2015

@wp9015362, we are still actively discussing this topic. I think you can expect updates within the next few days.

@rhansby
Copy link
Collaborator

rhansby commented Sep 24, 2015

Please see #256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants