fix click failure for emulated keys when using Android > 12 #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olling emulated keys to their maximum position to the left or right
kruton
force-pushed
the
fix_emulated_keyboard_onclick_for_android_12
branch
from
8430a21
to
289e395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scrolling emulated keys to their maximum position to the left or right on Android 12 or later, clicking the keys does not initate a response. This seems to be connected to the overscroll stretch effect introduced with Android 12 (https://developer.android.com/about/versions/12/behavior-changes-all#overscroll).
Setting
android:overScrollMode="never"for the corresponding
HorizontalScrollViewfixes that.