Fix a lot of issues, add Error Prone, etc.

[kruton]

No description provided.

[stickler-ci]

Running checkstyle failed with:

com.puppycrawl.tools.checkstyle.api.CheckstyleException: unable to parse configuration stream

Ensure your config file exists and is valid XML.

[stickler-ci]

Running checkstyle failed with:

com.puppycrawl.tools.checkstyle.api.CheckstyleException: unable to parse configuration stream

Ensure your config file exists and is valid XML.

[stickler-ci]

Running checkstyle failed with:

com.puppycrawl.tools.checkstyle.api.CheckstyleException: unable to parse configuration stream

Ensure your config file exists and is valid XML.

[fat-tire]

As long as you're doing all this... why are .iml files and .idea files being tracked at all? Probably should remove tracking from every file inside .idea and *.iml. In other words, git rm:

.idea/.gitignore
.idea/.name
.idea/codeStyleSettings.xml
.idea/copyright/Apache_ConnectBot.xml
.idea/copyright/profiles_settings.xml
.idea/encodings.xml
.idea/gradle.xml
.idea/runConfigurations/All_tests.xml
.idea/scopes/ConnectBot.xml
.idea/vcs.xml
.idea/.gitignore    <-- why is this even here?
app/app.iml
connectbot.iml

and then modify .gitignore to add:

*.iml

[kruton]

It holds the code style settings among other things.

[fat-tire]

I think anything in .idea/ is regenerated/overwritten as-needed by Android Studio (the gradle build scripts) Delete it and it will all be recreated. The iml files may be needed though, but I thought they would be recreated too. Maybe not (?)

[stickler-ci]

Running checkstyle failed with:

com.puppycrawl.tools.checkstyle.api.CheckstyleException: unable to parse configuration stream

Ensure your config file exists and is valid XML.

[coveralls]

Coverage increased (+0.2%) to 33.851% when pulling a72d732 on kruton:testing-updates into 7303255 on connectbot:master.