Support ssh-rsa host keys with sha2 signature #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for rsa-sha2-256 and rsa-sha2-512 host keys. The host key itself is still an rsa key but with sha2 signatures, so there is no new code needed to decode the host key. The sha2 signatures are already supported, too.
|
|
|
Thanks. I think this also needs to modify the integration tests to save to |
kruton
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for rsa-sha2-256 and rsa-sha2-512 host keys. The host key
itself is still an rsa key but with sha2 signatures, so there is no new code
needed to decode the host key. The sha2 signatures are already supported, too.
This will fix connectbot/connectbot#698 (after updating the library in connectbot).