Add salt and timing safe compare #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NinnOgTonic
reviewed
Oct 26, 2018
sample/simpleidp/index.js
Outdated
| @@ -39,7 +39,8 @@ app.use('/api/login', (req, res) => { | |||
| let username = req.body.username | |||
|
|
|||
| // Here we do a simple hashed password check | |||
| crypto.pbkdf2(password, 'salt', 100000, 64, 'sha512', (err, derivedKey) => { | |||
| const salt = crypto.randomBytes(16) | |||
There was a problem hiding this comment.
If you want per-password salts, instead of a global one, you should store this together with the hashed password? And use it for the verification-encoding?
NinnOgTonic
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.