Cd/add metrics logger #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module that keeps maintains a global singleton variable to retain metric state and log them on demand. References: connectedcars/api#854
Global singletons are close to impossible to mock properly.
concats name and labels into a key
Function getPrometheusMetrics assumed that metrics.labels was always set. This commit makes a precheck to handle the case of no labels.
|
@mathiastj do we have any node 6 projects that we should be compatible with? |
|
I can't find any, so I think we're good. |
|
Should probably update the README to show how to use the new format. |
added 7 commits
January 16, 2019 10:41
Keys did not include the label name, thus causing possible colissions. Also, logMetrics was iterating the values instead of the keys.
The default switch can never be reached. Only if the API consumer is fiddling around with this.metrics and adds bogus keys and values.
startTime is not used on gauge type. Only cumulative type.
Also adapts existing tests to cover the changes in the prev. commits
mathiastj
approved these changes
Jan 16, 2019
|
Just talked to @mathiastj : It probably makes sense to make |
added 2 commits
January 16, 2019 14:40
the `gauge()` function now takes an extra argument, thus making it possible to do other than takes the last value
mathiastj
reviewed
Jan 16, 2019
| const key = this.createKey(name, labels) | ||
| const metric = this.metrics[key] |
There was a problem hiding this comment.
Make sure to be consistent, i.e. in the cumulative function too
added 2 commits
January 16, 2019 15:09
Eventually the timestamps will end up on Google Custom Metrics and they expect ISO-8601 timestamps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.