Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version const to create v1.0.0-rc1 release #710

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

jhump
Copy link
Member

@jhump jhump commented Nov 27, 2023

Although the Makefile and gorelease config are smart enough to put the right version number here, it's also nice to edit the constant so that someone just doing go build ... will still see the correct number reported. (The make and release config stuff is mostly a fallback, so that at least the official binaries will print the correct version even if we forget to edit this.)

Once merged, this commit will be tagged and released, and then I'll open another PR to set it to v1.0.0-rc2-dev.

@jhump jhump requested a review from smaye81 November 27, 2023 22:49
@jhump jhump merged commit 88fd21b into main Nov 27, 2023
5 checks passed
@jhump jhump deleted the jh/1.0.0-rc1 branch November 27, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants