Run all non-TLS-specific test cases through TLS server #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cent network activity' http3 issues?
jhump
force-pushed
the
jh/more-tls-tests
branch
from
8809aa4
to
8e01800
Compare
smaye81
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively adds a lot more test cases for TLS servers. Previously, only test cases that required TLS were run against TLS servers. Now, all test cases are run against TLS servers.
We still only run test cases that require client certs when using the client cert configuration. But for TLS servers without client certs, we run 'em all.
I ran into some gross issues with HTTP/3 with this branch, which is where the changes to the reference client and server come from.