Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wire tracer capabilities to reference client #768

Merged
merged 46 commits into from
Feb 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
a91e67f
Tracer
smaye81 Jan 25, 2024
7f26eeb
Tracer
smaye81 Jan 26, 2024
fd0b009
Tracer
smaye81 Jan 26, 2024
76d823e
Revert
smaye81 Jan 26, 2024
3198a13
Revert
smaye81 Jan 26, 2024
2f87a7f
Revert
smaye81 Jan 26, 2024
fbb79ff
LOgging
smaye81 Jan 26, 2024
b2ba9b3
Impl
smaye81 Jan 26, 2024
8049ab9
Update
smaye81 Jan 27, 2024
8106bf7
Update
smaye81 Jan 27, 2024
ead36d4
Raw json
smaye81 Jan 30, 2024
543f288
Merge branch 'main' into sayers/http_tracer
smaye81 Jan 30, 2024
985292e
Content
smaye81 Jan 30, 2024
c2448f1
Tracing
smaye81 Jan 30, 2024
5ba1f02
Revert go.mod
smaye81 Jan 30, 2024
aa57ce8
Revert
smaye81 Jan 30, 2024
21b7974
Lint
smaye81 Jan 30, 2024
c8db7a5
Docs
smaye81 Jan 30, 2024
e4d2c2f
Revert
smaye81 Jan 30, 2024
92d60c8
Merge branch 'main' into sayers/http_tracer
smaye81 Jan 31, 2024
a132b49
Fixes
smaye81 Feb 1, 2024
411aa13
Docs
smaye81 Feb 1, 2024
8c46e10
Race condition
smaye81 Feb 1, 2024
b47a710
Revert
smaye81 Feb 1, 2024
57d8635
Tracer
smaye81 Feb 1, 2024
d53c5e4
Tests
smaye81 Feb 2, 2024
25337a7
Tracer
smaye81 Feb 2, 2024
a83c12e
Tracer
smaye81 Feb 2, 2024
76a7496
Tests
smaye81 Feb 2, 2024
03bd905
Docs
smaye81 Feb 2, 2024
c8ba9c4
Revert
smaye81 Feb 2, 2024
b3baf63
Tests
smaye81 Feb 2, 2024
4263999
Remove debug
smaye81 Feb 2, 2024
af03a89
Merge branch 'main' into sayers/http_tracer
smaye81 Feb 2, 2024
ff03486
Simplify
smaye81 Feb 3, 2024
0906002
Feedback
smaye81 Feb 6, 2024
aa0a862
Impl
smaye81 Feb 6, 2024
67fe5d2
Wire Details
smaye81 Feb 6, 2024
0122e39
Lint
smaye81 Feb 6, 2024
f8cd911
Add TODO
smaye81 Feb 6, 2024
2537552
Feedback
smaye81 Feb 7, 2024
b4bba18
Temp disable breaking step
smaye81 Feb 7, 2024
a2e3f6d
Slim down the breaking comments
smaye81 Feb 7, 2024
e38b33c
Merge branch 'main' into sayers/http_tracer
smaye81 Feb 7, 2024
50df580
Relaxes assertions on query parameters (#771)
jhump Feb 7, 2024
ba04755
Merge
smaye81 Feb 7, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/buf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,11 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: bufbuild/buf-setup-action@v1
- uses: bufbuild/buf-breaking-action@v1.1.3
with:
input: proto
against: 'buf.build/connectrpc/conformance'
# TODO - Reenable after pushing breaking proto changes to BSR
# - uses: bufbuild/buf-breaking-action@v1.1.3
smaye81 marked this conversation as resolved.
Show resolved Hide resolved
# with:
# input: proto
# against: 'buf.build/connectrpc/conformance'
push:
runs-on: ubuntu-latest
if: github.ref == 'refs/heads/main'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -267,18 +267,10 @@ export class ClientResponseResult extends jspb.Message {
getNumUnsentRequests(): number;
setNumUnsentRequests(value: number): ClientResponseResult;

getActualStatusCode(): number;
setActualStatusCode(value: number): ClientResponseResult;

getConnectErrorRaw(): google_protobuf_struct_pb.Struct | undefined;
setConnectErrorRaw(value?: google_protobuf_struct_pb.Struct): ClientResponseResult;
hasConnectErrorRaw(): boolean;
clearConnectErrorRaw(): ClientResponseResult;

getActualHttpTrailersList(): Array<connectrpc_conformance_v1_service_pb.Header>;
setActualHttpTrailersList(value: Array<connectrpc_conformance_v1_service_pb.Header>): ClientResponseResult;
clearActualHttpTrailersList(): ClientResponseResult;
addActualHttpTrailers(value?: connectrpc_conformance_v1_service_pb.Header, index?: number): connectrpc_conformance_v1_service_pb.Header;
getWireDetails(): WireDetails | undefined;
setWireDetails(value?: WireDetails): ClientResponseResult;
hasWireDetails(): boolean;
clearWireDetails(): ClientResponseResult;

serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): ClientResponseResult.AsObject;
Expand All @@ -295,9 +287,7 @@ export namespace ClientResponseResult {
error?: connectrpc_conformance_v1_service_pb.Error.AsObject,
responseTrailersList: Array<connectrpc_conformance_v1_service_pb.Header.AsObject>,
numUnsentRequests: number,
actualStatusCode: number,
connectErrorRaw?: google_protobuf_struct_pb.Struct.AsObject,
actualHttpTrailersList: Array<connectrpc_conformance_v1_service_pb.Header.AsObject>,
wireDetails?: WireDetails.AsObject,
}
}

Expand All @@ -319,3 +309,33 @@ export namespace ClientErrorResult {
}
}

export class WireDetails extends jspb.Message {
getActualStatusCode(): number;
setActualStatusCode(value: number): WireDetails;

getConnectErrorRaw(): google_protobuf_struct_pb.Struct | undefined;
setConnectErrorRaw(value?: google_protobuf_struct_pb.Struct): WireDetails;
hasConnectErrorRaw(): boolean;
clearConnectErrorRaw(): WireDetails;

getActualHttpTrailersList(): Array<connectrpc_conformance_v1_service_pb.Header>;
setActualHttpTrailersList(value: Array<connectrpc_conformance_v1_service_pb.Header>): WireDetails;
clearActualHttpTrailersList(): WireDetails;
addActualHttpTrailers(value?: connectrpc_conformance_v1_service_pb.Header, index?: number): connectrpc_conformance_v1_service_pb.Header;

serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): WireDetails.AsObject;
static toObject(includeInstance: boolean, msg: WireDetails): WireDetails.AsObject;
static serializeBinaryToWriter(message: WireDetails, writer: jspb.BinaryWriter): void;
static deserializeBinary(bytes: Uint8Array): WireDetails;
static deserializeBinaryFromReader(message: WireDetails, reader: jspb.BinaryReader): WireDetails;
}

export namespace WireDetails {
export type AsObject = {
actualStatusCode: number,
connectErrorRaw?: google_protobuf_struct_pb.Struct.AsObject,
actualHttpTrailersList: Array<connectrpc_conformance_v1_service_pb.Header.AsObject>,
}
}

Loading
Loading