Fix deflate algorithm to adhere to RFC 1950
#824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
reviewed
Mar 12, 2024
zlib.Reader eagerly reads the zlib header, so it cannot be constructed without a reader. Instead of using Reset, just defer constructing the reader.
jhump
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't default to testing
deflateright now, as far as I can tell, but this is a pretty potent footgun so I think it is definitely worth getting right.Though it is not explicitly specified anywhere I can find, gRPC seems to follow HTTP in treating
deflateas RFC 1950 (zlib) instead of RFC 1951 (deflate).The
deflateInit2function's documentation can be found online here. But briefly:windowBitsis [-15, -8], raw deflate (RFC 1951) is used.windowBitsis [8, 15], deflate with zlib header (RFC 1950) is used.windowBitsis [24, 31], deflate with gzip header (RFC 1952) is used.Following this, we can see that gRPC will use either gzip (for the
gzipencoding) or zlib (for thedeflateencoding.)