Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @bufbuild/protobuf to dependencies #496

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Add @bufbuild/protobuf to dependencies #496

merged 2 commits into from
Mar 1, 2023

Conversation

fubhy
Copy link
Contributor

@fubhy fubhy commented Feb 27, 2023

Fixed #432.

@unicomp23
Copy link

@smaye81 @timostamm looks like I'm getting hit by this one as well?

@unicomp23
Copy link

#500

@unicomp23
Copy link

Please disregard my rambling above. import_extension when added to the "opt:" list in buf.yaml does the trick.

https://github.com/bufbuild/connect-es/blob/79c385fc417094c2681cc02b00ac269b1499ee54/packages/protoc-gen-connect-es/README.md#import_extensionjs

@smaye81 smaye81 merged commit 9c2ca01 into connectrpc:main Mar 1, 2023
@fubhy fubhy deleted the add-protobuf-dep branch March 1, 2023 19:59
@smaye81 smaye81 mentioned this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependency declaration for @bufbuild/protobuf
3 participants