Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix response header management in Fastify plugin #517

Merged
merged 5 commits into from
Mar 7, 2023
Merged

Fix response header management in Fastify plugin #517

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2aad2fc
Fix headers
smaye81 Mar 7, 2023
63bc85c
Fastify
smaye81 Mar 7, 2023
291648a
Better comments
smaye81 Mar 7, 2023
c1cb656
Merge branch 'main' into sayers/fix_response_headers
smaye81 Mar 7, 2023
33e8be1
Fixed comment
smaye81 Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/connect-fastify/src/fastify-connect-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,14 @@ export function fastifyConnectPlugin(
req.body as JsonValue | undefined
)
);
// Fastify maintains response headers on the reply object and only moves them to
// the raw response during reply.send, but we are not using reply.send with this plugin.
// So we need to manually copy them to the raw response before handing off to vanilla Node.
for (const [key, value] of Object.entries(reply.getHeaders())) {
if (value !== undefined) {
reply.raw.setHeader(key, value);
}
}
await universalResponseToNodeResponse(uRes, reply.raw);
}
);
Expand Down