Fix unhandledRejection when aborting a server stream using @bufbuild/connect-node
#530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ghost
mentioned this pull request
timostamm
changed the title
unhandledRejection when aborting a server stream using @bufbuild/connect-node
timostamm
reviewed
Mar 14, 2023
There was a problem hiding this comment.
Great spot!
However, I am not sure that ignoring the error is the right solution. I have the impression that the
sentinel.catch()earlier in the code makes it safe to do so, but am I wrong?
Yes, that's correct. Any errors should propagate through the response (body).
|
Sorry for the forced push, I made a mistake in the commit message... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello ! 😄
I think I have solved the issue #476. If I understood correctly, the call
sentinel.finally()returns a newPromise, whose failure was never catched.However, I am not sure that ignoring the error is the right solution. I have the impression that the
sentinel.catch()earlier in the code makes it safe to do so, but am I wrong?Thank you very much in advance!