Add from() and findDetails() to ConnectError #638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two methods to ConnectError:
The static
from()
, which converts any error into a ConnectError, if it is not already a ConnectError:This is a replacement for connectErrorFromReason(), which is deprecated with this PR. The static method is more discoverable, and it does not require a separate import.
And the instance method
findDetails
():This is a replacement for connectErrorDetails(), which is deprecated with this PR. The instance method is more discoverable, does not require a separate import, and has a more descriptive name.
The standalone function has one override accepting multiple message types that the new method does not implement. The simple workaround is to use a registry:
This change adds 1% to the bundle size according to our code size comparison, but the improved developer experience seems worth it.