Support CommonJS in protoc-gen-connect-es #956
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to @bufbuild/protoplugin v1.6.0 and support CommonJS with the new plugin option:
js_import_style
By default, protoc-gen-connect-es (and all other plugins based on @bufbuild/protoplugin) generate ECMAScript
import
andexport
statements. For use cases where CommonJS is difficult to avoid, this option can be used to generate CommonJSrequire()
calls.Possible values:
js_import_style=module
generate ECMAScriptimport
/export
statements - the default behavior.js_import_style=legacy_commonjs
generate CommonJSrequire()
calls.