-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we version the protoc plugin separately from the main package? #35
Comments
@amckinney What do you think? It seems simple to me to keep the same version for both, calling out changes to the plugin in the changelog. If users end up running into problems with code generated by a plugin that's newer than their runtime, the solution is super-clear: plugin version must be <= runtime version. We'll have plugin version releases that don't change anything, but that seems like it's not a big deal to me? |
I would be hard against separate versioning, this seems anti-KISS and
against the simplicity of thought we’re trying to give users compared to
grpc-go
…On Fri, Feb 11, 2022 at 9:13 PM Akshay Shah ***@***.***> wrote:
@amckinney <https://github.com/amckinney> What do you think? It seems
simple to me to keep the same version for both, calling out changes to the
plugin in the changelog. If users end up running into problems with code
generated by a plugin that's newer than their runtime, the solution is
super-clear: plugin version must be <= runtime version.
We'll have plugin version releases that don't change anything, but that
seems like it's not a big deal to me?
—
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAINPAIPJCCMYLJMTTI4QTU2W653ANCNFSM5LVQDJ5Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I agree, leave it out. |
I don't see much benefit in this, but grpc-go and Alex's branch both do it.
The text was updated successfully, but these errors were encountered: