Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we version the protoc plugin separately from the main package? #35

Closed
akshayjshah opened this issue Jan 11, 2022 · 3 comments
Closed

Comments

@akshayjshah
Copy link
Member

I don't see much benefit in this, but grpc-go and Alex's branch both do it.

@akshayjshah
Copy link
Member Author

@amckinney What do you think? It seems simple to me to keep the same version for both, calling out changes to the plugin in the changelog. If users end up running into problems with code generated by a plugin that's newer than their runtime, the solution is super-clear: plugin version must be <= runtime version.

We'll have plugin version releases that don't change anything, but that seems like it's not a big deal to me?

@bufdev
Copy link
Member

bufdev commented Feb 12, 2022 via email

@amckinney
Copy link
Contributor

I agree, leave it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants