Update dependencies (incl. golangci-lint) #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
akshayjshah
commented
Aug 16, 2022
akshayjshah
commented
- Lint on Go 1.19
- Use new Godoc links
- Update deps, including golangci-lint
Unless new syntax is backward-incompatible, we should lint on the most recent Go supported Go version. This PR changes lint to run on Go 1.19 and mechanically reformats comments with `gofmt -s -w .`.
Where possible, use Go 1.19's new Godoc links to refer to types, packages, and external websites.
Update to latest golangci-lint (and other deps). Update to fix lint from checks that now support generics.
pkwarren
approved these changes
Aug 16, 2022
cmd/protoc-gen-connect-go/main.go
Outdated
| // out: gen | ||
| // version: v1 | ||
| // plugins: | ||
| // name: go |
There was a problem hiding this comment.
Shouldn't there be a '-' before each name to separate plugins?
alexandrem
pushed a commit
to alexandrem/connect-go
that referenced
this pull request
Aug 17, 2022
* Lint on Go 1.19 Unless new syntax is backward-incompatible, we should lint on the most recent Go supported Go version. This PR changes lint to run on Go 1.19 and mechanically reformats comments with `gofmt -s -w .`. * Use new Godoc links Where possible, use Go 1.19's new Godoc links to refer to types, packages, and external websites. * Update deps, including golangci-lint Update to latest golangci-lint (and other deps). Update to fix lint from checks that now support generics.
akshayjshah
added a commit
that referenced
this pull request
Jul 26, 2023
* Lint on Go 1.19 Unless new syntax is backward-incompatible, we should lint on the most recent Go supported Go version. This PR changes lint to run on Go 1.19 and mechanically reformats comments with `gofmt -s -w .`. * Use new Godoc links Where possible, use Go 1.19's new Godoc links to refer to types, packages, and external websites. * Update deps, including golangci-lint Update to latest golangci-lint (and other deps). Update to fix lint from checks that now support generics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.